0.2.66 - End Credits improvements / Gateway: 0.1.47 - End credits redesign

server/internal/scheduler/scheduler_test.go

@@ -219,3 +219,44 @@ func waitForRun(t *testing.T, sched *Scheduler, id string) Status {
 }
 
 var _ sync.Locker = (*sync.Mutex)(nil)
+
+// The console needs both cadences to draw its control honestly: the one in force and the
+// one the code declares. Reporting only the effective interval made "every ten minutes
+// because that is the default" and "every ten minutes because somebody chose it" identical
+// on the wire, so nothing could offer a way back to the default or mark a task as no longer
+// running as shipped.
+func TestSnapshotReportsTheDeclaredCadenceBesideTheEffectiveOne(t *testing.T) {
+	sched := quietScheduler()
+	sched.Register(Task{ID: "credits", Name: "Credits", Interval: 10 * time.Minute, Run: noop})
+
+	before := sched.Snapshot()[0]
+	if before.Interval != 600 || before.DefaultInterval != 600 {
+		t.Fatalf("unoverridden task: interval %d, default %d, want 600 and 600",
+			before.Interval, before.DefaultInterval)
+	}
+
+	if err := sched.SetInterval(context.Background(), "credits", time.Hour); err != nil {
+		t.Fatalf("SetInterval: %v", err)
+	}
+	after := sched.Snapshot()[0]
+	if after.Interval != 3600 {
+		t.Fatalf("effective interval %d, want 3600", after.Interval)
+	}
+	// The declared cadence must survive the override, or the way back is lost.
+	if after.DefaultInterval != 600 {
+		t.Fatalf("declared cadence %d, want 600 — an override must not overwrite it",
+			after.DefaultInterval)
+	}
+}
+
+// A task that declares no cadence at all runs only when somebody presses the button, and
+// the console has to be able to say so rather than printing "every 0 seconds".
+func TestATaskWithNoDeclaredCadenceReportsZeroForBoth(t *testing.T) {
+	sched := quietScheduler()
+	sched.Register(Task{ID: "manual", Name: "Manual", Run: noop})
+
+	status := sched.Snapshot()[0]
+	if status.Interval != 0 || status.DefaultInterval != 0 {
+		t.Fatalf("interval %d, default %d, want 0 and 0", status.Interval, status.DefaultInterval)
+	}
+}