0.2.54

server/internal/api/analytics.go

@@ -6,6 +6,8 @@ import (
 	"net/http"
 	"strings"
 	"time"
+	"unicode"
+	"unicode/utf8"
 
 	"github.com/ponzischeme89/memby/server/internal/store"
 )
@@ -41,7 +43,7 @@ type journeyEventPayload struct {
 	Feature    string `json:"feature"`
 	Source     string `json:"source"`
 	Target     string `json:"target"`
-	ItemID     string `json:"itemId"`
+	ItemName   string `json:"itemName"`
 	ItemType   string `json:"itemType"`
 	Outcome    string `json:"outcome"`
 	OccurredAt string `json:"occurredAt"`
@@ -98,17 +100,21 @@ func toJourneyEvent(payload journeyEventPayload, userID string, now time.Time) (
 		!journeyOutcomes[payload.Outcome] {
 		return store.JourneyEvent{}, false
 	}
-	fields := []string{payload.Screen, payload.Feature, payload.Source, payload.Target, payload.ItemID, payload.ItemType}
+	fields := []string{payload.Screen, payload.Feature, payload.Source, payload.Target, payload.ItemType}
 	for _, field := range fields {
 		if !safeAnalyticsValue(field, 100) {
 			return store.JourneyEvent{}, false
 		}
 	}
+	if utf8.RuneCountInString(payload.ItemName) > 160 ||
+		strings.IndexFunc(payload.ItemName, unicode.IsControl) >= 0 {
+		return store.JourneyEvent{}, false
+	}
 	occurredAt := analyticsOccurredAt(payload.OccurredAt, now)
 	return store.JourneyEvent{OccurredAt: occurredAt, UserID: userID, JourneyID: payload.JourneyID,
 		Sequence: payload.Sequence, Category: payload.Category, Action: payload.Action,
 		Screen: payload.Screen, Feature: payload.Feature, Source: payload.Source,
-		Target: payload.Target, ItemID: payload.ItemID, ItemType: payload.ItemType,
+		Target: payload.Target, ItemName: strings.TrimSpace(payload.ItemName), ItemType: payload.ItemType,
 		Outcome: payload.Outcome}, true
 }