0.2.79 - Slow api fixes

server/internal/api/playback.go

@@ -14,6 +14,7 @@ import (
 	serverlogging "github.com/ponzischeme89/memby/server/internal/logging"
 	"github.com/ponzischeme89/memby/server/internal/notify"
 	"github.com/ponzischeme89/memby/server/internal/store"
+	"github.com/ponzischeme89/memby/server/internal/timing"
 )
 
 const ticksPerMillisecond = 10_000
@@ -826,7 +827,8 @@ func (s *Server) handlePlaybackReport(w http.ResponseWriter, r *http.Request, se
 	)
 
 	err := s.emby.ReportPlayback(
-		r.Context(), credentials(sess), phase, report.ItemID, report.MediaSourceID,
+		timing.WithLabel(r.Context(), "emby.report"),
+		credentials(sess), phase, report.ItemID, report.MediaSourceID,
 		report.PlaySessionID, report.PlayMethod, report.EventName,
 		max64(report.PositionMs, 0)*ticksPerMillisecond, report.IsPaused,
 	)
@@ -873,18 +875,27 @@ func (s *Server) handlePlaybackReport(w http.ResponseWriter, r *http.Request, se
 		playbackSessionKey(sess.DeviceID, report.PlaySessionID))
 
 	if phase == "stopped" {
+		invalidate := timing.Start(r.Context(), "invalidate")
 		if err := s.cache.InvalidateUser(r.Context(), sess.EmbyUserID); err != nil {
 			s.loggerFor(r.Context()).Warn("cache invalidation failed", "error", err)
 		}
+		invalidate()
 		// Recommendation taste changes slowly. Tracearr marks this user's prepared
 		// profile dirty only when the session first becomes terminal; the daily builder
 		// then refreshes it without turning every player exit into catalogue-wide work.
 	}
 
 	response := playbackReportResponse{}
+	// The order of these three is the whole of what keeps a progress report cheap. The
+	// claim is a map lookup and comes first, so every report after the first for this
+	// episode stops here rather than at the durable insert four upstream calls later;
+	// the feature check is a cached read; and only then is anything asked of Emby.
 	if shouldAutoFollowShow(phase, report.PositionMs, report.DurationMs) &&
+		s.followChecks.claim(sess.EmbyUserID, report.ItemID) &&
 		s.featureEnabled(r.Context(), featureAutomaticMyShows) {
+		follow := timing.Start(r.Context(), "autofollow")
 		response.AutoFollowedShowTitle = s.autoFollowContinuingShow(r.Context(), sess, report.ItemID)
+		follow()
 	}
 	writeJSON(w, http.StatusOK, response)
 }